Add puppet8 certificate renewal endpoint. #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
force-pushed
the
certificate_renewal_endpoint
branch
from
256e2e4
to
70f9dbf
Compare
ekohl
requested changes
Jan 3, 2024
Comment on lines
+12
to
+14
| allow-auto-renewal: <%= @server_ca_allow_auto_renewal %> | ||
| # This value determines the lifetime of the cert if auto-renewal is enabled | ||
| auto-renewal-cert-ttl: <%= @server_ca_allow_auto_renewal_cert_ttl %> |
There was a problem hiding this comment.
These values are not known in the scope, so they don't get replaced. That causes the build to fail:
CI failures are related:
Dec 28 19:30:38 centos9-64-puppet8.example.com puppetserver[2140]: /etc/puppetlabs/puppetserver/conf.d/ca.conf: 14: Expecting close brace } or a comma, got ':' (if you intended ':' to be part of a key or string value, try enclosing the key or value in double quotes)
You need to add them to puppet::server (and further) as well.
jcpunk
force-pushed
the
certificate_renewal_endpoint
branch
from
70f9dbf
to
ac3c426
Compare
|
Hmmmm, that endpoint doesn't appear to work with puppet7. Is the |
jcpunk
changed the title
|
We used to have |
jcpunk
force-pushed
the
certificate_renewal_endpoint
branch
from
ac3c426
to
62d076b
Compare
ekohl
reviewed
Jan 3, 2024
jcpunk
force-pushed
the
certificate_renewal_endpoint
branch
3 times, most recently
from
0ff35a6
to
d5b736d
Compare
From https://www.puppet.com/docs/puppet/8/server/http_certificate_renew Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
jcpunk
force-pushed
the
certificate_renewal_endpoint
branch
from
d5b736d
to
52d57e5
Compare
ekohl
requested changes
Feb 13, 2024
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
ekohl
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.puppet.com/docs/puppet/8/server/http_certificate_renew