Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow permissions change of puppet.conf #847

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Allow permissions change of puppet.conf #847

merged 3 commits into from
Jan 30, 2023

Conversation

teluq-pbrideau
Copy link
Contributor

There is confidential info in my puppet.conf (http_proxy_password to be precise) that I would like to secure from unprivileged users.

@teluq-pbrideau
Copy link
Contributor Author

I don’t understand why the check failed… The two warnings in manifest/server/config.pp are not changed I made. And if I run bundle exec rake validate lint check on my laptop, there is about 2000 lines of errors, and none seems to be about my changes. What do I miss?

@ekohl
Copy link
Member

ekohl commented Sep 26, 2022

I think I need to finish #841 first.

ekohl
ekohl reviewed Jan 30, 2023
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
@teluq-pbrideau @ekohl
refactor: use Stdlib::Filemode instead of Regex
8d190e5 
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@ekohl ekohl merged commit 71af87f into theforeman:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
Enhancement Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teluq-pbrideau @ekohl @theforeman-bot