Add Array of Integers as valid type for run_minute #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that one failed test has something to do with my change. Can you please check @ekohl ? Thank you very much |
|
It would be great to have this merged: at the moment this bug causes puppet to change the crontab entry at each run. |
ehelms
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no value for
run_minuteis specified the module internally uses https://forge.puppet.com/modules/puppet/extlib/reference#extlibip_to_cronThis function returns an array of integers as values that then are passed to the cron/systemd timer resources.
Having a list of values is not currently possible if you set the value of
run_minutevia the class.This change allows specifying the minute you want as an Array of integers.