Add server_jolokia_metrics_whitelist parameter
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also accept a special value that turns on unauthenticated access, instead of populating the ie Variant[Enum['NOAUTH'],Array[String[1]]]Or maybe also accept Variant[Boolean, Array[String[1]]]Or maybe a whitelist is overly complicated and I should have gone for a simple boolean! |
|
rebased. @ekohl Does this look ok? |
ekohl
approved these changes
Apr 4, 2022
manifests/init.pp
Outdated
| @@ -537,6 +537,10 @@ | |||
| # invokes when on static_file_content requests. | |||
| # Defaults to undef | |||
| # | |||
| # $server_jolokia_metrics_whitelist:: The whitelist of clients that | |||
| # can query the jolokia /metrics/v2 endpoint | |||
| # Defaults to [] | |||
There was a problem hiding this comment.
IMHO there's no need to document the default.
There was a problem hiding this comment.
Removed and rebased.
When set, allows listed clients access to the V2 (jolokia) metrics endpoint. See https://puppet.com/docs/puppet/7/server/metrics-api/v2/metrics_api.html
ekohl
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, allows listed clients access to the V2 (jolokia) metrics
endpoint.
See https://puppet.com/docs/puppet/7/server/metrics-api/v2/metrics_api.html