Remove Puppet start workaround on Debian #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
reviewed
Sep 27, 2021
Back with Puppet 3 there was a workaround to not start Puppet by default but since Debian Jessie ([854487]) this no longer exists. It now uses regular init integration. This also doesn't affect AIO which never implemented it this way. [854487]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854487
ekohl
force-pushed
the
remove-old-debian-workaround
branch
from
6cf9013
to
cf3a707
Compare
ehelms
approved these changes
Oct 11, 2021
evgeni
approved these changes
Oct 19, 2021
| @@ -616,7 +614,6 @@ | |||
| Array[String] $auth_allowed = $puppet::params::auth_allowed, | |||
| Variant[String, Array[String]] $client_package = $puppet::params::client_package, | |||
| Boolean $agent = $puppet::params::agent, | |||
| Boolean $remove_lock = $puppet::params::remove_lock, | |||
There was a problem hiding this comment.
this makes it a backwards-incompatible change, right?
There was a problem hiding this comment.
Correct so I added the Backwards incompatible label to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back with Puppet 3 there was a workaround to not start Puppet by default but since Debian Jessie (854487) this no longer exists. It now uses regular init integration. This also doesn't affect AIO which never implemented it this way.