Fix config append #782
Merged
Fix config append #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyNamedLaura
force-pushed
the
fix-config-append
branch
from
3a808af
to
8efea88
Compare
added 2 commits
March 25, 2021 20:45
LadyNamedLaura
force-pushed
the
fix-config-append
branch
2 times, most recently
from
c425e2b
to
ed77327
Compare
ekohl
approved these changes
Mar 29, 2021
| @@ -73,6 +73,12 @@ | |||
| puppet::config::main { $key: value => $value } | |||
| } | |||
|
|
|||
| concat::fragment { 'puppet.conf_comment': | |||
| target => "${puppet_dir}/puppet.conf", | |||
| content => '# file managed by puppet', | |||
There was a problem hiding this comment.
This is a nice solution to the otherwise empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #759.
I start by reverting #707 and re-implementing a fix for it. the actual fix was actually quiet easy, just by adding a concat snippet at the end of each config block with a newline.