Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for change from puppet master to server #770

Closed
wants to merge 1 commit into from

Conversation

tbrisker
Copy link
Member

Puppet has been using server naming since 5.x, and the puppet master
implementation is long deprecated and unsupported. Additionally,
compile masters have been renamed to compilers in 6.x. Updating
our documentation to use the current nomenclature.
No parameters were renamed to preserve backwards compatibility.
Additionally, to minimize changes no changes were made with regards to
capitalization or refering to puppetserver vs. puppet server

Puppet has been using `server` naming since 5.x, and the puppet master
implementation is long deprecated and unsupported. Additionally,
`compile masters` have been renamed to `compilers` in 6.x. Updating
our documentation to use the current nomenclature.
No parameters were renamed to preserve backwards compatibility.
Additionally, to minimize changes no changes were made with regards to
capitalization or refering to `puppetserver` vs. `puppet server`
@@ -80,7 +80,7 @@ wrapper classes or even your ENC (if it supports param classes). For example:
# Agent and cron (or daemon):
class { '::puppet': runmode => 'cron' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but I should do a follow up that also removes ::. That was a Puppet 3/4 compatibility thing we no longer need to care about.

# $ca_crl_sync:: Sync the puppet ca crl to compile masters. Requires compile masters to
# be agents of the CA master (MOM) defaults to false
# $ca_crl_sync:: Sync the puppet ca crl to compilers. Requires compilers to
# be agents of the CA server (MOM) defaults to false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOM here refers to Master of Masters. I'm not sure what the new term for that is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2019.8 docs state:

"We've unified infrastructure terminology across all installation types. We now call compile masters compilers to reflect their role: compiling catalogs. Similarly, we call the master a master, whether or not your installation includes compilers. In high availability installations, the node that replicates data from the master is simply a replica. R.I.P. MoM, master of masters, and primary master replica."

but tbh i'm not sure i understand what is supposed to replace MoM? simply Master? how does that fit with the change from master to server everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binford2k not sure who could answer this. Would you mind taking a look or redirecting us to some source that documents it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this earlier. We're using "primary server" where we used to use MoM. So in HA you then have replicas of the primary. Compilers remain the same.

@@ -164,7 +164,7 @@
#
# $agent_noop:: Run the agent in noop mode.
#
# $puppetmaster:: Hostname of your puppetmaster (server
# $puppetmaster:: Hostname of your puppetserver (server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also need to update this, but I don't really know what a good name would be. agent_server is also not that clear and just server is already taken.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe agent_server_hostname?

@ehelms ehelms mentioned this pull request Jul 19, 2021
1 task
@tbrisker tbrisker closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants