Don't re-create existing CA certs #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zipkid
force-pushed
the
fix/ca_reuse_existing
branch
from
605b24d to
1045bbd
Compare
ekohl
approved these changes
May 27, 2020
|
Thanks! I've taken the liberty to squash and modify the commit message slightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a new puppetserver as CA with existing CA files, the current code tries to perform 'puppetserver ca setup' because the puppetserver's cert does not exist yet.
However, that command fails because the CA cert files exist and can, correctly, not be overwritten.
This PR changes checking for the CA cert, instead of the server's own cert.