Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement 'versioned code' for puppetserver #726

Merged
merged 1 commit into from
Mar 22, 2020
Merged

implement 'versioned code' for puppetserver #726

merged 1 commit into from
Mar 22, 2020

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Mar 8, 2020

No description provided.

@mmoll mmoll mentioned this pull request Mar 8, 2020
Closed
@mmoll
Copy link
Contributor Author

mmoll commented Mar 8, 2020

@ekohl If my changes are OK for you, I'll add tests.

@mmoll
Copy link
Contributor Author

mmoll commented Mar 21, 2020

Ready for review.

@mmoll mmoll closed this Mar 21, 2020
@mmoll mmoll reopened this Mar 21, 2020
ekohl
ekohl approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pry issue in beaker should be fixed so I restarted those. Otherwise 👍

@mmoll
Copy link
Contributor Author

mmoll commented Mar 22, 2020

💚

@ekohl ekohl merged commit db9611d into theforeman:master Mar 22, 2020
@ekohl
Copy link
Member

ekohl commented Mar 22, 2020

Thanks!

@mmoll mmoll deleted the pr_702 branch March 22, 2020 15:30
@bastelfreak
Copy link
Member

hey @mmoll , do you by any chance use this and have working examples for the required scripts?

@mmoll
Copy link
Contributor Author

mmoll commented Mar 23, 2020

@bastelfreak Sorry, nope... I just took up the PR of another user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmoll @ekohl @bastelfreak @theforeman-bot @wbclark