Implement $server_max_open_files #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
baurmatt
force-pushed
the
feature/maxopenfiles
branch
from
60120f2 to
07a2dc3
Compare
baurmatt
force-pushed
the
feature/maxopenfiles
branch
from
07a2dc3 to
169f74b
Compare
alexjfisher
approved these changes
Jan 24, 2019
ekohl
requested changes
Jan 24, 2019
baurmatt
force-pushed
the
feature/maxopenfiles
branch
from
169f74b to
51c36a9
Compare
ekohl
reviewed
Jan 24, 2019
baurmatt
force-pushed
the
feature/maxopenfiles
branch
from
51c36a9 to
ea1ecb3
Compare
Done! :)
Not really sure where to add it. Can you point me to a good place for it? :) |
This commit implements the $server_max_open_files parameter which allows the user to configure the max open file descriptor limit for Puppetserver. Fixes #theforemanGH-670.
baurmatt
force-pushed
the
feature/maxopenfiles
branch
from
ea1ecb3 to
597aac3
Compare
ekohl
approved these changes
Feb 14, 2019
| it_behaves_like 'a idempotent resource' | ||
|
|
||
| # pgrep -f java.*puppetserver would be better. But i cannot get it to work. Shellwords.escape() seems to break something | ||
| describe command("grep '^Max open files' /proc/`cat /var/run/puppetlabs/puppetserver/puppetserver.pid`/limits"), :sudo => true do |
There was a problem hiding this comment.
You may be able to parse this via systemctl status puppetserver as well. Both the main pid as the limit. On the other hand, this is a real test on the result so I'm fine with this.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the $server_max_open_files parameter which allows
the user to configure the max open file descriptor limit for
Puppetserver.
Fixes #670.