Add unmanaged Puppet Agent runmode #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this differ from runmode |
|
Left a comment here too: #383 Bottom line is I would like to be able to leave the service stopped while testing changes, undisturbed by the service. In that context I would also like to be able to enable the service without starting it, which I can do with a profile in the control-repository, but it's not currently possible to manually manage the service yourself as long as this module is used to install the agent. |
|
I'm OK with it after fixing 👍 |
|
Ha, you're right. The consistency OCD missed the fact that $::puppet::unavailable_runmodes is NOT a string. Things make sense now. Fixed. |
ekohl
approved these changes
Jan 11, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-383