Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for managing jetty threads #647

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Add support for managing jetty threads #647

merged 1 commit into from
Nov 13, 2018

Conversation

bastelfreak
Copy link
Member

@bastelfreak bastelfreak force-pushed the threads2 branch 3 times, most recently from 92cd294 to aef0b5f Compare November 2, 2018 14:19
@mmoll
Copy link
Contributor

mmoll commented Nov 2, 2018

@bastelfreak this needs a rebase :)

@bastelfreak bastelfreak closed this Nov 3, 2018
@bastelfreak bastelfreak reopened this Nov 3, 2018
@bastelfreak
Copy link
Member Author

@mmoll @ekohl can you review this please? I think the code is fine, but something is fishy with the acceptance tests on centos 6.

@mmoll
Copy link
Contributor

mmoll commented Nov 3, 2018

A test with these parameters set would be nice, looks fine visually.

@bastelfreak
Copy link
Member Author

I'm not sure yet why the new tests fail. I will have a look again later. Maybe somebody else has an idea.

ekohl
ekohl requested changes Nov 3, 2018
View reviewed changes
spec/classes/puppet_server_config_spec.rb Outdated Show resolved Hide resolved
mmoll
mmoll suggested changes Nov 3, 2018
View reviewed changes
manifests/init.pp Show resolved Hide resolved
@mmoll
Copy link
Contributor

mmoll commented Nov 3, 2018

@bastelfreak one tiny thing, otherwise IMHO ready to go :)

@mmoll mmoll changed the title Enable support for managing jetty threads Add support for managing jetty threads Nov 3, 2018
ekohl
ekohl requested changes Nov 5, 2018
View reviewed changes
spec/classes/puppet_server_puppetserver_spec.rb Outdated Show resolved Hide resolved
spec/classes/puppet_server_puppetserver_spec.rb Outdated Show resolved Hide resolved
@ekohl ekohl merged commit c95e761 into theforeman:master Nov 13, 2018
@ekohl
Copy link
Member

ekohl commented Nov 13, 2018

Thanks!

@bastelfreak bastelfreak deleted the threads2 branch November 13, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@mmoll mmoll mmoll approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastelfreak @mmoll @ekohl @theforeman-bot