Add reporter to report logs sent by foreman callback

[m-bucher]

When ansible fails to connect to remote host,
callback sends a report to Foreman without
any indication that the report comes from
Ansible. As a result, Foreman is unable
to determine the report origin.

This adds a 'reporter' attribute into
the logs that are sent.

Fixes #836

[mdellweg]

Sounds good

[ezr-ondrej]

Would it make sense to move this to the report

foreman-ansible-modules/plugins/callback/foreman.py

Line 204 in 8ebda3f

report = {

instead of duplicating this for every log?

[m-bucher]

@ezr-ondrej I agree that this would be better.

However, foreman_ansible seems to only get the list of logs for detecting the reporter:

https://github.com/theforeman/foreman_ansible/blob/344333df2905cdb7c8affbb9a1dbb03f6ef7619c/app/services/foreman_ansible/ansible_report_scanner.rb#L8

[ezr-ondrej]

For now I'd agree, but that can be changed quite "easily".
I'd say it's worth the effort. I'm willing to help as much as I can to get it done properly.
Given the ReportScanner only job is to recognize the report origin, I think it should get all info we see fit.
Take a look at my proposal: theforeman/foreman#7819

[evgeni]

today, foreman_ansible looks for _ansible_parsed, not for reporter = ansible, right? So the PR in the current state wouldn't work right now with the currently released foreman_ansible?

[m-bucher]

@evgeni correct, but I regard it as the first step to add a change here, before we adopt it in foreman_ansible.
If we can intertwine it with @ezr-ondrej proposed change in foreman that would be good, too.

[evgeni]

Cool, then I think Foreman and Foreman Ansible should agree on a way forward and then we can implement the right tag in the callback :)

[ezr-ondrej]

If we won't move forward with my suggestion soon, I'd say we can role with what is here now and change just ansible implementation and once we agree get it done in core, we can change the implementation here.

Implementation changed

[evgeni]

Now that theforeman/foreman#7819 is merged, I guess we need the matching change in foreman_ansible?

[evgeni]

and then probably set it like in https://github.com/theforeman/foreman-ansible-modules/pull/896/files to the global data, and not on every log object?

[ezr-ondrej]

@m-bucher could you update this to set it to the global data, please?
I believe this could go even first as the path is now given by foreman core and foreman-ansible needs to follow.

For the record, @xprazak2 is already working on it in theforeman/foreman_ansible#261

[evgeni]

LGTM!

@xprazak2 should we merge this now, or wait on theforeman/foreman_ansible#261 -- IMHO merging now is OK if you don't anticipate any design changes in foreman_ansible anymore

[ezr-ondrej]

I think we are good to merge, foreman_ansible have all means now to adjust to this and IMHO it's the best place to put the reporter tag to, so it should 🤷

[ezr-ondrej]

hmm what is the release process for this? 🤔

[evgeni]

This == this collection? We release new stuff here on GH, it gets pushed to Galaxy, the next time Ansible decides to pull new stuff (aka: next is for 2.10.1) it gets in.

[ezr-ondrej]

Yeah, I meant this collection :) thanks, I was just checking about the backwards compatibility we will need to get.
That case, I'd say we are ready for this, we will just need to have a talk about the backwards compatibility in foreman_ansible, but it's unrelated to this.

[evgeni]

The collection is usable by 2.8 and newer, but in the case of 2.8/2.9 the user needs to install it explicitly to get the callback, instead of getting it automatically.

[ezr-ondrej]

foreman_ansible is in and waiting for this, could we get it in now? 🙃

[evgeni]