Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology consistency alignment for presence -> motion and movement #451

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

DigiH
Copy link
Contributor

@DigiH DigiH commented Nov 13, 2023

Terminology consistency alignment

presence -> motion
for CGPR1, MUE4094RT

movement -> motion
SwitchBot Contact Sensor W120150X and SwitchBot Motion Sensor W110150X

motion -> moving
for SwitchBot Curtain W070160X

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH DigiH requested a review from 1technophile November 13, 2023 11:38
@DigiH DigiH force-pushed the presence branch 2 times, most recently from 9551078 to 43a0765 Compare November 13, 2023 17:31
Terminology consistency alignment

presence -> motion
for CGPR1, MUE4094RT

movement -> motion
SwitchBot Contact Sensor W120150X and SwitchBot Motion Sensor W110150X

motion -> moving
for SwitchBot Curtain W070160X

contact -> open
BSDOO and SBDW-002C
@DigiH DigiH merged commit 1f17669 into theengs:development Nov 13, 2023
@DigiH DigiH deleted the presence branch November 13, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants