fix: handle null path parameter in RestNodesCapabilitiesAction (elast…

…ic#113413)
thecoop · Sep 27, 2024 · 929b388 · 929b388
1 parent 074af78
commit 929b388
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/docs/changelog/113413.yaml b/docs/changelog/113413.yaml
@@ -0,0 +1,6 @@
+pr: 113413
+summary: Fixed a `NullPointerException` in `_capabilities` API when the `path` parameter is null.
+area: Infra/REST API
+type: bug
+issues:
+  - 113413
diff --git a/...rc/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesCapabilitiesAction.java b/...rc/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesCapabilitiesAction.java
@@ -54,9 +54,12 @@ protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient cli
             ? new NodesCapabilitiesRequest(client.getLocalNodeId())
             : new NodesCapabilitiesRequest();
 
+        // Handle the 'path' parameter, use "/" as default if not provided
+        String path = URLDecoder.decode(request.param("path", "/"), StandardCharsets.UTF_8);
+
         NodesCapabilitiesRequest r = requestNodes.timeout(getTimeout(request))
             .method(RestRequest.Method.valueOf(request.param("method", "GET")))
-            .path(URLDecoder.decode(request.param("path"), StandardCharsets.UTF_8))
+            .path(path)
             .parameters(request.paramAsStringArray("parameters", Strings.EMPTY_ARRAY))
             .capabilities(request.paramAsStringArray("capabilities", Strings.EMPTY_ARRAY))
             .restApiVersion(request.getRestApiVersion());