fix: do not incorrectly use real paths on exclude predicate #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
approved these changes
Dec 20, 2024
|
Hey, can we add a test case here? |
|
done 👍 let me know if you need anything else @thecodrr |
thecodrr
approved these changes
Dec 23, 2024
|
Thank you both for this! @thecodrr any chance we could get a release with this change? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the e18e discord for discussion, sorry i didn't have time to open an issue
the exclude predicate always used real paths on symlinks, this should fix that