Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for excluding symlinks #115

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

SuperchupuDev
Copy link
Contributor

when resolveSymlinks is not set, symlinks just get treated as files. this adds support for individually excluding symlinks from the result

why? because fdir currently has ways of excluding files and directories, but not symlinks (and also because it was requested in SuperchupuDev/tinyglobby#26)

src/api/walker.ts Outdated Show resolved Hide resolved
src/api/walker.ts Outdated Show resolved Hide resolved
@thecodrr
Copy link
Owner

We also need to not build resolveSymlinks function when excludeSymlinks is true.

@SuperchupuDev
Copy link
Contributor Author

done, let me know if i should change anything else 🙏

@thecodrr thecodrr merged commit 14b26d7 into thecodrr:master Sep 26, 2024
11 checks passed
@SuperchupuDev SuperchupuDev deleted the feat/exclude-symlinks branch September 26, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants