specify Safe\createFromMutable return changing type for php8.2 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've opened this PR one month ago, would it be possible to have a review ? |
|
Can we merge and release this? |
akondas
approved these changes
Feb 18, 2023
|
Sorry I stopped checking on the project for a will. Before I deploy this,, I need to fix a bunch of things, mostly related to all the functions that needs to be deprecated. I will have some holidays this week, hope I can get this project back in shape. |
|
this is deployed in v2.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating to PHP8.2 I have the following issue with Safe\createFromMutable
Adding #[\ReturnTypeWillChange] fixes it.
I don't know if it's the best solution, but it's my proposition.
Feel free to tell me what should be done if this not the appropriate solution