Codebase improvements with php 8.1 features #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make clearer types.
Make clearer types.
Remove support for PHP 8.0 test matrix
…ection types (OutputType&Type), new functions (str_starts_with,str_ends_with)
…ection types (OutputType&Type)
…ection types (e.g. OutputType&Type), match(){} syntax
|
@oojacoboo Is doc generation failed due to auto bumping |
|
@bladl I've updated docusaurus. Please try merging origin into your fork. |
|
@oojacoboo now all checks are passed. Please, review a PR |
oojacoboo
approved these changes
Feb 6, 2023
|
@bladl thanks for this - merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7953638 allows us to use all range of php 8.1 features.
I tried to improve some code.
There is list of changes:
switchtomatchsyntaxfinalkeyword for internal classesreadonlymodifier to private class propertiesGraphQLType&OutputType) with native. (Can be BREAKING for some specific external usage)