Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-php v15 #542

Merged
merged 27 commits into from
Jan 18, 2023
Merged

graphql-php v15 #542

merged 27 commits into from
Jan 18, 2023

Conversation

l-you
Copy link
Contributor

@l-you l-you commented Jan 12, 2023

We have 23 test errors after bumping webonyx version
#540

@l-you
Copy link
Contributor Author

l-you commented Jan 12, 2023

@oojacoboo Minimum supported php version for ecodev/graphql-upload is ^8.1. But we have continuous integration for php 8.0

@l-you
Copy link
Contributor Author

l-you commented Jan 12, 2023

Other test errors I will fix by myself

@l-you l-you marked this pull request as ready for review January 13, 2023 04:44
@l-you
Copy link
Contributor Author

l-you commented Jan 13, 2023

@oojacoboo
There was a bunch of breaking changes.
Finally, all php >8.0 tests passed. Please review a PR !

Remove support for PHP 8.0 test matrix
@oojacoboo
Copy link
Collaborator

oojacoboo commented Jan 13, 2023

Dropped 8.0 tests. I'll review the rest of the PR soon. Thanks for knocking this out!

@l-you
Copy link
Contributor Author

l-you commented Jan 13, 2023

Does it means we drop support for php 8.0? So we can use all range of php 8.1 features from now

@oojacoboo
Copy link
Collaborator

Yes, we'd basically be dropping 8.0 support and only supporting >=8.1 with this PR. However, I am wondering why ecodev/graphql-upload has minimum 8.1 support.

Also, I didn't check. What were the test errors surrounding 8.0?

@l-you
Copy link
Contributor Author

l-you commented Jan 14, 2023

Also, I didn't check. What were the test errors surrounding 8.0?

composer install failed so I did not run tests in php 8.0 enviroment.

@l-you
Copy link
Contributor Author

l-you commented Jan 14, 2023

While I was working for this and previous PR I felt a huge lack of native PHP intersection types. Many docblocks and assertions can be dropped with php 8.1.

With all range of php 8.1 features debugging codebase would be much simpler and I believe graphqlite will evolve much faster.
In my opinion it's worth to drop support for php 8.0 now in any case.

@oojacoboo oojacoboo merged commit cf81541 into thecodingmachine:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants