-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql-php v15 #542
graphql-php v15 #542
Conversation
@oojacoboo Minimum supported php version for ecodev/graphql-upload is ^8.1. But we have continuous integration for php 8.0 |
Other test errors I will fix by myself |
Make clearer types.
Make clearer types.
@oojacoboo |
Remove support for PHP 8.0 test matrix
Dropped 8.0 tests. I'll review the rest of the PR soon. Thanks for knocking this out! |
Does it means we drop support for php 8.0? So we can use all range of php 8.1 features from now |
Yes, we'd basically be dropping 8.0 support and only supporting >=8.1 with this PR. However, I am wondering why Also, I didn't check. What were the test errors surrounding 8.0? |
composer install failed so I did not run tests in php 8.0 enviroment. |
While I was working for this and previous PR I felt a huge lack of native PHP intersection types. Many docblocks and assertions can be dropped with php 8.1. With all range of php 8.1 features debugging codebase would be much simpler and I believe graphqlite will evolve much faster. |
We have 23 test errors after bumping webonyx version
#540