Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop doctrine/cache dependency #373

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

TamasSzigeti
Copy link
Contributor

Fixes #353

There are further possible improvements, trying to keep a smaller scope here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #373 (674408d) into master (0cd315a) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
+ Coverage     98.32%   98.41%   +0.09%     
+ Complexity     1578     1575       -3     
============================================
  Files           147      147              
  Lines          4245     4235      -10     
============================================
- Hits           4174     4168       -6     
+ Misses           71       67       -4     
Impacted Files Coverage Δ
src/SchemaFactory.php 100.00% <100.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd315a...674408d. Read the comment docs.

@TamasSzigeti TamasSzigeti marked this pull request as ready for review August 28, 2021 10:34
@oojacoboo oojacoboo merged commit d494448 into thecodingmachine:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package doesn't work with deprecated Doctrine Cache 2.0
3 participants