Bump version of phpdocumentor/type-resolver #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Florian, Sure! Let's merge this! |
|
Wohoo 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 🖖
as we have another dependency in our product that relies on
phpdocumentor/type-resolverwith version constraint~0.4 || ^1.0.0, folks usually have the current1.2.0installed. When someone now requires the GraphQL module, which currently relies on GraphQLite^3.1, composer will complain about this situation. This is due to the fact the composer will not make downgrades duringcomposer require. So the documented solution as of now is to require with the--no-updateflag and runcomposer updateafterwards.This PR would solve this problem for us. I know, that this is not a problem in GraphQLite and with the next major release of the OXID eShop and GraphQL module we plan on upgrading to GraphQLite
v4, but in the meantime this would solve us some support requests 😉Kind regards
Florian