Use relative URL for favicon #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes sites which have the baseURL in a subdirectory.
regisphilibert
requested changes
Feb 5, 2020
| <link rel="shortcut icon" href="{{ relURL ($.Site.Params.favicon) }}" type="image/x-icon" /> |
There was a problem hiding this comment.
Thanks again. And again could you do as for #252 and remove the () :)
Thanks a ton!
There was a problem hiding this comment.
May I make it easier to change? :)
Suggested change
| <link rel="shortcut icon" href="{{ relURL ($.Site.Params.favicon) }}" type="image/x-icon" /> | |
| <link rel="shortcut icon" href="{{ relURL $.Site.Params.favicon }}" type="image/x-icon" /> |
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
This fixes sites which have the baseURL in a subdirectory. Co-authored-by: Nick White <git@njw.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes sites which have the baseURL in a subdirectory.