This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
Added driver for cs43l22 audio DAC #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @forGGe |
| { | ||
| single = 0x40, // Play one beep | ||
| multiple = 0x80, // Play beep for on_time, mute for off_time | ||
| continuos = 0xC0, // Play continuously |
There was a problem hiding this comment.
Typo:
continuos -> continuous
|
Partial review |
| template < class I2c, class I2s, class Rst_gpio > | ||
| ecl::err cs43l22< I2c, I2s, Rst_gpio >::pcm_stream_stop() | ||
| { | ||
| ecl_assert(m_state & inited); |
There was a problem hiding this comment.
Here. we need to ensure that pcm_stream_start() is actually called previously and stream wasn't stopped yet.
|
/cc @forGGe addressed review comments. |
1) Updated description 2) Improved documentation 3) Added asserts 4) Fixed code style issues
forGGe
added a commit
that referenced
this pull request
Jul 14, 2016
Added driver for cs43l22 audio DAC
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.