Implement Disband Volume Group

theCheeseboard · Aug 15, 2023 · df1bf52 · df1bf52
1 parent ff59e24
commit df1bf52
Show file tree

Hide file tree

Showing 17 changed files with 417 additions and 9 deletions.
diff --git a/application/diskPanes/lvmdiskpane.cpp b/application/diskPanes/lvmdiskpane.cpp
@@ -48,7 +48,7 @@ void LvmDiskPane::updateDetails() {
 
     this->setVisible(true);
     auto pv = d->disk->interface<PhysicalVolumeInterface>();
-    if (pv) {
+    if (pv && pv->volumeGroup()) {
         ui->lvmDescription->setText(tr("This block is part of the %1 volume group.").arg(QLocale().quoteString(pv->volumeGroup()->name())));
         ui->evictDataButton->setVisible(true);
         ui->viewVgButton->setVisible(true);

diff --git a/application/lvm/volumegrouppage.cpp b/application/lvm/volumegrouppage.cpp
@@ -5,6 +5,8 @@
 #include <DriveObjects/diskobject.h>
 #include <DriveObjects/logicalvolume.h>
 #include <DriveObjects/volumegroup.h>
+#include <operations/disbandvgpopover.h>
+#include <tpopover.h>
 #include <volumegrouplvmodel.h>
 #include <volumegrouppvmodel.h>
 
@@ -77,4 +79,13 @@ void VolumeGroupPage::on_titleLabel_backButtonClicked() {
 }
 
 void VolumeGroupPage::on_disbandButton_clicked() {
+    auto* jp = new DisbandVgPopover(d->vg);
+    tPopover* popover = new tPopover(jp);
+    popover->setPopoverWidth(-200);
+    popover->setPopoverSide(tPopover::Bottom);
+    connect(jp, &DisbandVgPopover::done, popover, &tPopover::dismiss);
+    connect(jp, &DisbandVgPopover::deleted, this, &VolumeGroupPage::done);
+    connect(popover, &tPopover::dismissed, popover, &tPopover::deleteLater);
+    connect(popover, &tPopover::dismissed, jp, &DisbandVgPopover::deleteLater);
+    popover->show(this->window());
 }
diff --git a/libthefrisbee/CMakeLists.txt b/libthefrisbee/CMakeLists.txt
@@ -54,6 +54,7 @@ set(SOURCES
         volumegrouplvmodel.h volumegrouplvmodel.cpp
         volumegrouppvmodel.h volumegrouppvmodel.cpp
         operations/attachpvpopover.h operations/attachpvpopover.cpp operations/attachpvpopover.ui
+        operations/disbandvgpopover.h operations/disbandvgpopover.cpp operations/disbandvgpopover.ui
     )
 
 set(STRUCTURES_HEADERS

diff --git a/libthefrisbee/DriveObjects/volumegroup.cpp b/libthefrisbee/DriveObjects/volumegroup.cpp
@@ -1,17 +1,25 @@
 #include "volumegroup.h"
 #include "logicalvolume.h"
 
+#include <QCoroDBusPendingCall>
+#include <QDBusConnection>
+#include <QDBusMessage>
+#include <QDBusPendingCall>
+
 #include "DriveObjects/diskobject.h"
 #include "DriveObjects/physicalvolumeinterface.h"
 #include "driveobjectmanager.h"
+#include "frisbeeexception.h"
 
 struct VolumeGroupPrivate {
+        QDBusObjectPath path;
         QString name;
 };
 
 VolumeGroup::VolumeGroup(QDBusObjectPath path, QObject* parent) :
     UdisksInterface{path, interfaceName(), parent} {
     d = new VolumeGroupPrivate();
+    d->path = path;
 
     bindPropertyUpdater("Name", [this](QVariant value) {
         d->name = value.toString();
@@ -46,3 +54,11 @@ tRange<DiskObject*> VolumeGroup::pvs() {
 QString VolumeGroup::name() {
     return d->name;
 }
+
+QCoro::Task<> VolumeGroup::deleteVg(bool wipe, QVariantMap options) {
+    QDBusMessage message = QDBusMessage::createMethodCall("org.freedesktop.UDisks2", d->path.path(), interfaceName(), "Delete");
+    message.setArguments({wipe, options});
+    auto call = QDBusConnection::systemBus().asyncCall(message);
+    auto reply = co_await call;
+    if (call.isError()) throw FrisbeeException(call.error().message());
+}
diff --git a/libthefrisbee/DriveObjects/volumegroup.h b/libthefrisbee/DriveObjects/volumegroup.h
@@ -2,6 +2,7 @@
 #define VOLUMEGROUP_H
 
 #include "udisksinterface.h"
+#include <QCoroTask>
 #include <ranges/trange.h>
 
 struct VolumeGroupPrivate;
@@ -19,6 +20,8 @@ class VolumeGroup : public UdisksInterface {
 
         QString name();
 
+        QCoro::Task<> deleteVg(bool wipe, QVariantMap options);
+
     signals:
         void lvsChanged();
         void pvsChanged();

diff --git a/libthefrisbee/operations/disbandvgpopover.cpp b/libthefrisbee/operations/disbandvgpopover.cpp
@@ -0,0 +1,35 @@
+#include "disbandvgpopover.h"
+#include "ui_disbandvgpopover.h"
+
+#include "DriveObjects/volumegroup.h"
+#include <tcontentsizer.h>
+
+struct DisbandVgPopoverPrivate {
+        VolumeGroup* vg;
+};
+
+DisbandVgPopover::DisbandVgPopover(VolumeGroup* vg, QWidget* parent) :
+    QWidget(parent),
+    ui(new Ui::DisbandVgPopover) {
+    ui->setupUi(this);
+    d = new DisbandVgPopoverPrivate();
+    d->vg = vg;
+
+    new tContentSizer(ui->disbandConfirmWidget);
+    ui->disbandButton->setProperty("type", "destructive");
+}
+
+DisbandVgPopover::~DisbandVgPopover() {
+    delete d;
+    delete ui;
+}
+
+void DisbandVgPopover::on_disbandButton_clicked() {
+    d->vg->deleteVg(false, {});
+    emit deleted();
+    emit done();
+}
+
+void DisbandVgPopover::on_titleLabel_backButtonClicked() {
+    emit done();
+}
diff --git a/libthefrisbee/operations/disbandvgpopover.h b/libthefrisbee/operations/disbandvgpopover.h
@@ -0,0 +1,33 @@
+#ifndef DISBANDVGPOPOVER_H
+#define DISBANDVGPOPOVER_H
+
+#include <QWidget>
+
+namespace Ui {
+    class DisbandVgPopover;
+}
+
+class VolumeGroup;
+struct DisbandVgPopoverPrivate;
+class DisbandVgPopover : public QWidget {
+        Q_OBJECT
+
+    public:
+        explicit DisbandVgPopover(VolumeGroup* vg, QWidget* parent = nullptr);
+        ~DisbandVgPopover();
+
+    signals:
+        void done();
+        void deleted();
+
+    private slots:
+        void on_disbandButton_clicked();
+
+        void on_titleLabel_backButtonClicked();
+
+    private:
+        Ui::DisbandVgPopover* ui;
+        DisbandVgPopoverPrivate* d;
+};
+
+#endif // DISBANDVGPOPOVER_H
diff --git a/libthefrisbee/operations/disbandvgpopover.ui b/libthefrisbee/operations/disbandvgpopover.ui
@@ -0,0 +1,105 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>DisbandVgPopover</class>
+ <widget class="QWidget" name="DisbandVgPopover">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>692</width>
+    <height>523</height>
+   </rect>
+  </property>
+  <property name="windowTitle">
+   <string>Form</string>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="spacing">
+    <number>0</number>
+   </property>
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>
+   <item>
+    <widget class="tTitleLabel" name="titleLabel">
+     <property name="text">
+      <string>Disband Volume Group</string>
+     </property>
+    </widget>
+   </item>
+   <item alignment="Qt::AlignHCenter">
+    <widget class="QWidget" name="disbandConfirmWidget" native="true">
+     <layout class="QVBoxLayout" name="verticalLayout_4">
+      <item>
+       <widget class="QLabel" name="label_3">
+        <property name="font">
+         <font>
+          <bold>true</bold>
+         </font>
+        </property>
+        <property name="text">
+         <string>THIS IS IT</string>
+        </property>
+       </widget>
+      </item>
+      <item>
+       <widget class="QLabel" name="label_4">
+        <property name="text">
+         <string>There's no going back after this. Once the Volume Group is disbanded, all the logical volumes contained within, and all the data in the logical volumes will be gone forever.</string>
+        </property>
+        <property name="wordWrap">
+         <bool>true</bool>
+        </property>
+       </widget>
+      </item>
+      <item>
+       <widget class="QPushButton" name="disbandButton">
+        <property name="text">
+         <string>Disband Volume Group</string>
+        </property>
+        <property name="icon">
+         <iconset theme="edit-delete">
+          <normaloff>.</normaloff>.</iconset>
+        </property>
+       </widget>
+      </item>
+     </layout>
+    </widget>
+   </item>
+   <item>
+    <spacer name="verticalSpacer">
+     <property name="orientation">
+      <enum>Qt::Vertical</enum>
+     </property>
+     <property name="sizeHint" stdset="0">
+      <size>
+       <width>20</width>
+       <height>40</height>
+      </size>
+     </property>
+    </spacer>
+   </item>
+  </layout>
+ </widget>
+ <customwidgets>
+  <customwidget>
+   <class>tTitleLabel</class>
+   <extends>QLabel</extends>
+   <header location="global">ttitlelabel.h</header>
+   <slots>
+    <signal>backButtonClicked()</signal>
+   </slots>
+  </customwidget>
+ </customwidgets>
+ <resources/>
+ <connections/>
+</ui>
diff --git a/libthefrisbee/operations/eraseopticalpopover.ui b/libthefrisbee/operations/eraseopticalpopover.ui
@@ -209,14 +209,6 @@
   </layout>
  </widget>
  <customwidgets>
-  <customwidget>
-   <class>tTitleLabel</class>
-   <extends>QLabel</extends>
-   <header location="global">ttitlelabel.h</header>
-   <slots>
-    <signal>backButtonClicked()</signal>
-   </slots>
-  </customwidget>
   <customwidget>
    <class>tStackedWidget</class>
    <extends>QStackedWidget</extends>
@@ -226,6 +218,14 @@
     <signal>switchingFrame(int)</signal>
    </slots>
   </customwidget>
+  <customwidget>
+   <class>tTitleLabel</class>
+   <extends>QLabel</extends>
+   <header location="global">ttitlelabel.h</header>
+   <slots>
+    <signal>backButtonClicked()</signal>
+   </slots>
+  </customwidget>
  </customwidgets>
  <resources/>
  <connections/>

diff --git a/libthefrisbee/translations/cs.ts b/libthefrisbee/translations/cs.ts
@@ -40,6 +40,30 @@
         <translation type="unfinished"></translation>
     </message>
 </context>
+<context>
+    <name>DisbandVgPopover</name>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="14"/>
+        <source>Form</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="35"/>
+        <location filename="../operations/disbandvgpopover.ui" line="67"/>
+        <source>Disband Volume Group</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="50"/>
+        <source>THIS IS IT</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="57"/>
+        <source>There&apos;s no going back after this. Once the Volume Group is disbanded, all the logical volumes contained within, and all the data in the logical volumes will be gone forever.</source>
+        <translation type="unfinished"></translation>
+    </message>
+</context>
 <context>
     <name>DiskObject</name>
     <message>

diff --git a/libthefrisbee/translations/cs_CZ.ts b/libthefrisbee/translations/cs_CZ.ts
@@ -40,6 +40,30 @@
         <translation type="unfinished"></translation>
     </message>
 </context>
+<context>
+    <name>DisbandVgPopover</name>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="14"/>
+        <source>Form</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="35"/>
+        <location filename="../operations/disbandvgpopover.ui" line="67"/>
+        <source>Disband Volume Group</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="50"/>
+        <source>THIS IS IT</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="57"/>
+        <source>There&apos;s no going back after this. Once the Volume Group is disbanded, all the logical volumes contained within, and all the data in the logical volumes will be gone forever.</source>
+        <translation type="unfinished"></translation>
+    </message>
+</context>
 <context>
     <name>DiskObject</name>
     <message>

diff --git a/libthefrisbee/translations/da.ts b/libthefrisbee/translations/da.ts
@@ -40,6 +40,34 @@
         <translation type="unfinished"></translation>
     </message>
 </context>
+<context>
+    <name>DisbandVgPopover</name>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="14"/>
+        <source>Form</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="35"/>
+        <location filename="../operations/disbandvgpopover.ui" line="67"/>
+        <source>Disband Volume Group</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="50"/>
+        <source>THIS IS IT</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../operations/disbandvgpopover.ui" line="57"/>
+        <source>There&apos;s no going back after this. Once the Volume Group is disbanded, all the logical volumes contained within, and all the data in the logical volumes will be gone forever.</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>There&apos;s no going back after this. Once the disc in the drive is erased, all the data on it will be gone forever.</source>
+        <translation type="obsolete">Du kan ikke gå tilbage efter dette. Når disken i drevet er formateret, vil alle dataene på den være væk for evigt.</translation>
+    </message>
+</context>
 <context>
     <name>DiskObject</name>
     <message>