Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keyboard Promenade RP24S #2386

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Adding keyboard Promenade RP24S #2386

merged 4 commits into from
Dec 18, 2024

Conversation

Feags
Copy link
Contributor

@Feags Feags commented Dec 9, 2024

Adding VIA keymap for Promenade RP24S

Description

Adding promenade_rp24s.json

QMK Pull Request

QMK PR#24689

VIA Keymap Pull Request

qmk_userspace_via PR#39

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Feags added 3 commits December 9, 2024 07:40
Adding Promenade RP24S
Changed name of keyboard from "rp24s" to "Promenade RP24S"
@Feags Feags marked this pull request as ready for review December 10, 2024 00:46
@Cipulot Cipulot merged commit 3c881a7 into the-via:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants