Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SINGA Kohaku #2361

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Add SINGA Kohaku #2361

merged 2 commits into from
Nov 9, 2024

Conversation

itsme-zeix
Copy link
Contributor

@itsme-zeix itsme-zeix commented Oct 30, 2024

Description

Add VIA support for SINGA Kohaku

QMK Pull Request

qmk/qmk_firmware#24309

VIA Keymap Pull Request

https://github.com/the-via/qmk_userspace_via/pull/19/files

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Nov 9, 2024

@itsme-zeix keymap in the VIA rep was approved, if this PR is ok to be reviewed for merge flag it and I'll get to it asap. Asking since I don't want to review and possibly merge something that may not be 100% final and up to date, flagging it will tell me that it's ready.
Cheers

@itsme-zeix itsme-zeix marked this pull request as ready for review November 9, 2024 16:22
@itsme-zeix
Copy link
Contributor Author

@Cipulot Done! Thank you so much for the quick review! Really appreciate the work you've done taking over some of the VIA maintenance.

v3/zeix/singa/kohaku/kohaku.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit c6131a7 into the-via:master Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants