Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create KK65.json #2149

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Create KK65.json #2149

merged 2 commits into from
Feb 4, 2024

Conversation

apricity-spam
Copy link
Contributor

Added KK65.json to keyboards.

Description

Added KK65.json to keyboards for my limited run keyboard.

QMK Pull Request

qmk/qmk_firmware#22772

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@apricity-spam
Create KK65.json
c838eb0 
Added KK65.json to keyboards.
Xelus22
Xelus22 requested changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

looks like someone else already uses the same VID/PID.

@apricity-spam
Updated VID
2316fee 
Updated VID to remove conflict with other keyboard.
@apricity-spam
Copy link
Contributor Author

I updated the VID to remove the conflict. I have submitted a pull request with the QMK repository to change the VID as well.

@apricity-spam apricity-spam requested a review from Xelus22 February 3, 2024 03:05
@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 3, 2024

I updated the VID to remove the conflict. I have submitted a pull request with the QMK repository to change the VID as well.

Thanks. Could you also link that QMK PR?

@apricity-spam
Copy link
Contributor Author

QMK PR Link: qmk/qmk_firmware#23007

@apricity-spam
Copy link
Contributor Author

QMK PR has been merged

@Xelus22 Xelus22 merged commit 3c823b9 into the-via:master Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apricity-spam @Xelus22