Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laser Ninja Pumpkinpad #2116

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Add Laser Ninja Pumpkinpad #2116

merged 3 commits into from
Feb 25, 2024

Conversation

zykrah
Copy link
Contributor

@zykrah zykrah commented Dec 13, 2023

Description

As per title.

QMK Pull Request

QMK: https://github.com/qmk/qmk_firmware/tree/master/keyboards/laser_ninja/pumpkin_pad/keymaps/via

Note: There is a pending pull request to change the naming in QMK. Hence, I have opened this pull request matching the new naming.

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@laser-ninja
Copy link

Hey just confirming that zykrah is doing these PRs for me.

@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 3, 2024

@zykrah please fix :) CI/CD

@zykrah
Copy link
Contributor Author

zykrah commented Feb 18, 2024

Fixed

@Xelus22 Xelus22 merged commit a35e9dd into the-via:master Feb 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants