Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KindaKeyboards Conone65 Via support #2069

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add KindaKeyboards Conone65 Via support #2069

merged 2 commits into from
Nov 13, 2023

Conversation

mattchan
Copy link
Contributor

@mattchan mattchan commented Nov 1, 2023

Description

This adds a v3 JSON file for the Kindakeyboards Conone65.

QMK Pull Request

qmk/qmk_firmware#22320

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Nov 5, 2023
View reviewed changes
v3/kindakeyboards/conone65/conone65.json Outdated Show resolved Hide resolved
@mattchan @Xelus22
Remove QMK lighting options from Conone65
d078254 
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
@mattchan mattchan requested a review from Xelus22 November 6, 2023 16:12
@Xelus22 Xelus22 merged commit b46919d into the-via:master Nov 13, 2023
2 checks passed
@mattchan mattchan deleted the kindakeyboards-conone65 branch September 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattchan @Xelus22