Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for acr87. #1904

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Add VIA support for acr87. #1904

merged 2 commits into from
Jun 24, 2023

Conversation

jonylee1986
Copy link
Contributor

Description

Add VIA support for acr87.(V3)

QMK Pull Request

qmk/qmk_firmware#21200

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jun 18, 2023
View reviewed changes
v3/akko/acr87/acr87.json Outdated Show resolved Hide resolved
@jonylee1986 jonylee1986 requested a review from Xelus22 June 20, 2023 06:11
@Xelus22 Xelus22 merged commit 33d71d5 into the-via:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonylee1986 @Xelus22