Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KBDCraft Adam64 #1831

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Add KBDCraft Adam64 #1831

merged 4 commits into from
Apr 24, 2023

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Apr 20, 2023 •
edited
Loading

This will only add in the v3 JSON for the Adam64 as v2 are no longer required from what I understand.

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@adophoxia
Copy link
Contributor Author

The board is now merged into qmk/qmk_firmware, so best to get this merged.

Xelus22
Xelus22 requested changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in the accents and modifiers. Everything else looks good.

@adophoxia
Copy link
Contributor Author

Colors for accents and modifiers have been added, @Xelus22.
image

@Xelus22 Xelus22 merged commit 886d3d0 into the-via:master Apr 24, 2023
@adophoxia adophoxia deleted the kbdcraft-adam64 branch April 24, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adophoxia @Xelus22