Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Durgod Hades ISO version #1822

Merged
merged 1 commit into from
May 29, 2023

Conversation

ebastler
Copy link
Contributor

This PR adds support for Durgod Hades ISO, v2 (irrelevant as QMK PR has only just taken place) and v3.

Description

I renamed the ANSI Hades configs from hades.json to hades_ansi.json, and added hades_iso.json files.

QMK PR has been merged onto develop branch, not master, so not 100% sure if this will be accepted just yet? It will end up on master next dev merge.

QMK Pull Request

qmk/qmk_firmware#20110

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Apr 22, 2023

Will merge on next dev -> master merge.

@Xelus22
Copy link
Collaborator

Xelus22 commented May 29, 2023

yay dev merged

@Xelus22 Xelus22 merged commit f0cd734 into the-via:master May 29, 2023
@ebastler ebastler deleted the durgod_hades_iso branch May 29, 2023 09:22
@ebastler
Copy link
Contributor Author

Thanks Xelus, you merged this before I even noticed the dev merge was through :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants