Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ToffeeStudio blueberry #1773

Merged
merged 4 commits into from
Mar 26, 2023
Merged

Conversation

ToffeeStudio
Copy link
Contributor

Description

QMK Pull Request

qmk/qmk_firmware#19915

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

## Description

## QMK Pull Request 

qmk/qmk_firmware#19915

## Checklist

- [X] The VIA support for this keyboard is **MERGED** in QMK master already **(MANDATORY)**
- [X] The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
- [X] I have a V3 JSON version for this keyboard definition.**(MANDATORY)**
- [X] I have tested this keyboard definition using VIA's "Design" tab.
- [X] I have tested this keyboard definition with firmware on a device.
- [X] I have assigned alpha keys and modifier keys with the correct colors.
- [X] The Vendor ID is not `0xFEED`
@Xelus22
Copy link
Collaborator

Xelus22 commented Mar 21, 2023

Is there any legacy pcbs with V2? As this has just been merged. (we're trying to not add anything to V2 moving forward unless in extreme circumstances). If not please remove the V2 (src folder) defintion.

@ToffeeStudio
Copy link
Contributor Author

ToffeeStudio commented Mar 21, 2023

this isnt a V2 board, hasnt been out of gb as of yet either
been following what other people have added and they had those in their PRs as well

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have no backlight at all in QMK configuration?

Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
@Xelus22 Xelus22 merged commit f34271d into the-via:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants