New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created via design for djinn #1705

Merged

yiancar merged 1 commit into the-via:master from nilestanner:djinn

Feb 28, 2023

Contributor

nilestanner commented Feb 18, 2023 •

edited

Loading

Description

Adding design for Djinn, includes encoders and 5 way switches

QMK Pull Request

qmk/qmk_firmware#19881

Checklist

The VIA support for this keyboard is in QMK master already (MANDATORY)
The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
I have tested this keyboard definition using VIA's "Design" tab.
I have tested this keyboard definition with firmware on a device.
I have assigned alpha keys and modifier keys with the correct colors.
The Vendor ID is not 0xFEED


          Created via design for djinn

0edbcf8

Collaborator

yiancar commented Feb 28, 2023

Cheers thanks!

yiancar merged commit cee9b0b into the-via:master

Contributor Author

nilestanner commented Mar 2, 2023

@yiancar looks like the qmk change had not been merged. Is that an issue?

Collaborator

yiancar commented Mar 2, 2023

Yes it is part of the checklist... I am sorry I will have to revert the merge until it is done so

yiancar mentioned this pull request

Revert "Created via design for djinn" #1723

Merged

Collaborator

yiancar commented Mar 2, 2023

Please let me know once it is merged in qmk

Contributor Author

nilestanner commented Mar 8, 2023

@yiancar the qmk PR is merged should I reopen this one?

Collaborator

yiancar commented Mar 8, 2023

@nilestanner yes please can you just recreate the PR

Cheers

Contributor Author

nilestanner commented Mar 9, 2023

recreated here #1739 @yiancar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet