Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Add back tox #316

Merged
merged 5 commits into from
Feb 27, 2018
Merged

Add back tox #316

merged 5 commits into from
Feb 27, 2018

Conversation

ovv
Copy link
Contributor

@ovv ovv commented Feb 27, 2018

It seems to be running fine with the exact same file as before

@ovv
Copy link
Contributor Author

ovv commented Feb 27, 2018

It would probably be good to add a test for the documentation build in travis & tox but I'm not sure how it's built at the moment.

@@ -0,0 +1,22 @@
# Tox (http://tox.testrun.org/) is a tool for running tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to roll this file's content into setup.cfg? I'd just like to limit the number .ini files littered about if I can help it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik tox requires a tox.ini but it uses the setup.cfg and others files to get tools configuration. Like for pycodestyle.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox doesn't require a tox.ini (now), setup.cfg can be used with a [tox:tox] section. Leaving this here because it's highly ranked on a search engine. :)

@danielquinn danielquinn merged commit 81d92fb into the-paperless-project:master Feb 27, 2018
@danielquinn
Copy link
Collaborator

Ah I see now. There appears to be quite the controversy about the whole setup.cfg thing so I'm just going to keep my nose out of it.

Thanks so much for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants