Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(item sheets): add max height #97

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

stanavdb
Copy link
Collaborator

@stanavdb stanavdb commented Oct 22, 2024

Type

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
This PR gives item sheets a max height. This makes it so that items with a lot of options (like weapons) don't take up the entire screen height.

Related Issue
Closes #92

How Has This Been Tested?
Opened an Item of each type and navigated to the details tab to verify the max height was applied properly (where needed).

Screenshots (if applicable)
image

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas. (Not relevant)
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • I have tested my changes on Foundry VTT version: 12.331.

@stanavdb stanavdb self-assigned this Oct 22, 2024
@stanavdb stanavdb merged commit 8e49597 into release-0.1.1 Oct 22, 2024
1 check passed
@stanavdb stanavdb deleted the feat/item-details-scrollable-92 branch October 22, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant