feat(data): add injuries support to character data model #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work is completed on this PR. There's space for future improvements, like adding active effects support, but that's outside of the scope of this PR and the linked issue |
stanavdb
requested changes
Aug 20, 2024
src/system/config.ts
Outdated
Comment on lines
107
to
126
| injuries: { | ||
| [InjuryDuration.FleshWound]: { | ||
| label: 'Flesh Wound', | ||
| durationFormula: '1', | ||
| }, | ||
| [InjuryDuration.ShallowInjury]: { | ||
| label: 'Shallow Injury', | ||
| durationFormula: '1d6', | ||
| }, | ||
| [InjuryDuration.ViciousInjury]: { | ||
| label: 'Vicious Injury', | ||
| durationFormula: '6d6', | ||
| }, | ||
| [InjuryDuration.PermanentInjury]: { | ||
| label: 'Permanent Injury', | ||
| }, | ||
| [InjuryDuration.Death]: { | ||
| label: 'Death', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
These labels need to be localized
There was a problem hiding this comment.
Whoops! Didn't notice that localization is in because I'm forked from main. I'll get those changes in shortly
NoahJGersh
force-pushed
the
injury-data-model
branch
from
c28d97f to
b4b4eab
Compare
|
Alright, we're all localized now after a bit of repo rejiggering to be completely up-to-date with the release branch |
stanavdb
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5
Adding injury support to the character data model. While injuries themselves (among other conditions) should be Items or some other kind of EmbeddedDocument that lives in a character, we also want easy access to the number of injuries one has among their other conditions. We'll want a derived field for quick access to the number of injuries for Injury Rolls, as well as particular support for Injury Items.
Done:
injuriesfield in the common actor data modelInjuryitem typeduration)injuriesdata from owned Injury items