[Feature] Localization Implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary semi-colon - Type conversions through unknown
Optimize d20Roll Return
Start Player Actions Translations
Subsequent i18n path fixes in relevant files.
chatterchats
commented
Aug 12, 2024
There was a problem hiding this comment.
Lots of things that I didn't personally touch, due to linting it looks like. Primary files were
- rollup.config.js (Included src/lang and src/fonts in copy)
- src/system.json (Added languages section)
- src/index.ts (Localization of Sheet Labels)
- src/templates/*.hbs (Converted to {{ localize }} for labels)
- src/system/config.ts (Labels to i18n path)
- src/system/types/cosmere.ts (enum values to 18n paths were relevant)
- src/system/dict/plot-die.ts (localization of Complication and Opportunity)
remove duplicate code
chatterchats
changed the title
# Conflicts: # package-lock.json
|
I apologize for dumping another merge on you, but after this everything should match as per lint and prettier config. Can you change the base to release-0.1.0? Will review ASAP |
# Conflicts: # .github/workflows/lint.yml # eslint.config.mjs # rollup.config.js # src/declarations/foundry/client/config.d.ts # src/declarations/foundry/client/data/abstract/client-document.d.ts # src/declarations/foundry/client/data/documents/actor.d.ts # src/declarations/foundry/client/data/documents/item.d.ts # src/declarations/foundry/client/dice/roll.d.ts # src/declarations/foundry/common/abstract/data.d.ts # src/declarations/foundry/common/documents/actor.d.ts # src/declarations/foundry/common/documents/chat-message.d.ts # src/declarations/foundry/common/documents/item.d.ts # src/index.ts # src/style.scss # src/style/sheets/actor/character.scss # src/style/sheets/module.scss # src/style/sheets/sheet.scss # src/system.json # src/system/applications/actor/base-sheet.ts # src/system/applications/actor/character-sheet.ts # src/system/applications/actor/index.ts # src/system/applications/index.ts # src/system/config.ts # src/system/data/actor/common.ts # src/system/data/actor/index.ts # src/system/data/index.ts # src/system/data/item/action.ts # src/system/data/item/ancestry.ts # src/system/data/item/equipment.ts # src/system/data/item/fabrial.ts # src/system/data/item/index.ts # src/system/data/item/mixins/damaging.ts # src/system/data/item/mixins/description.ts # src/system/data/item/mixins/equippable.ts # src/system/data/item/mixins/id.ts # src/system/data/item/mixins/physical.ts # src/system/data/item/mixins/typed.ts # src/system/data/item/path.ts # src/system/data/item/talent.ts # src/system/data/item/weapon.ts # src/system/dice/d20-roll.ts # src/system/dice/index.ts # src/system/dice/plot-die.ts # src/system/dice/types.ts # src/system/documents/actor.ts # src/system/documents/index.ts # src/system/types/config.ts # src/system/types/roll.ts
|
@stanavdb Changed base to release-0.1.0, resolved merge conflicts, and retested to ensure functionality! Should be good for review |
stanavdb
requested changes
Aug 14, 2024
stanavdb
requested changes
Aug 14, 2024
stanavdb
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the Foundry Localization system.
Type of change
How Has This Been Tested?
Verified that all implemented sections of the Player Character Sheet were properly pulling from the localization files.
Test Configuration:
Checklist:
fixes #3