fix(attack roll): fix issue causing damage rolls not to respect their skill/attribute config #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… skill/attribute config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This PR fixes an issue causing damage rolls that are part of an attack, not to respect their skill/attribute overrides.
Related Issue
Closes #101
How Has This Been Tested?
Created an item with different skills/attributes configured for the skill test and damage roll. Added the item to an Actor that had different values for said skills. Used the item and checked if the appropriate modifier were present.
Screenshots (if applicable)
Checklist: