-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overencode; fix double-decode #10
Conversation
Note that we're using |
@@ -76,7 +79,7 @@ export default class CEd { | |||
this.id = block.id | |||
let el = document.createElement('div') | |||
el.innerHTML = this.block.html | |||
this.editor.setValue(decodeHTML(el.textContent)) | |||
this.editor.setValue(decode(el.textContent)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this decode
? Seems like el.textContent
would already be decoded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug: turns &
into &
expected &
dummy el.textContent works
discussion the-grid/ced#10
fix overencode; fix double-decode
Switch to
he
Also fix a double-decode bug where
&
would show as&
instead of expected&