-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header Design & Carousel Base + About page #64
Conversation
Visit the preview URL for this PR (updated for commit a14d5a9): https://tcl-77-smart-shopping-list--pr64-bb-header-design-599hqdog.web.app (expires Thu, 24 Oct 2024 22:03:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
* adding the borders and positioning the text areas on the page * figuring out some spacing on thank you & creators with theme-colors set * getting the lin icons to space evenly and the same on all of them * fixing the margins of the page for the whole about page * getting the base of the carousel with image working * card title on carousel card
…ere just beige not sure why but fixed
The carousel is a skeleton with a sample picture once we get the designing finished screen shots can be taken and it can be finished but as a base it is ready. |
These changes look incredible!!! So much work and passion went into this. What does the whole team think about having the carousel captions displayed to the left or right of the carousel image? It'd be easier to visually see and follow the directions with the image...I think. I know the carousel is a work in progress still, and subject to a lot more changes as we go! :) Also! I like that you're using the word skeleton now hahaha!!! |
@RossaMania your catch help me realized I put the wrong preview link in the tests but also made me double check what is looked like on my phone 🤦🏽♀️😂 The button maybe needs to be adjusted but it should fit on the screen and change. I'm not near a computer to check but I will! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Moving the navigation up to the top position and adding our design to the links, header and the sign out button. It should change to a hamburger on smaller screens and still work to navigate through the app. Added the sigma design to the about page and got the skeleton of the carousel we will need the pictures before it can be completed.
Related Issue
Closes #53 , #54 , #42
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria