Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Design & Carousel Base + About page #64

Merged
merged 20 commits into from
Oct 17, 2024
Merged

Header Design & Carousel Base + About page #64

merged 20 commits into from
Oct 17, 2024

Conversation

bbland1
Copy link
Collaborator

@bbland1 bbland1 commented Oct 9, 2024

Description

Moving the navigation up to the top position and adding our design to the links, header and the sign out button. It should change to a hamburger on smaller screens and still work to navigate through the app. Added the sigma design to the about page and got the skeleton of the carousel we will need the pictures before it can be completed.

Related Issue

Closes #53 , #54 , #42

Acceptance Criteria

  • Get the navigation/header styled based on design
  • Make sure still works as it did
  • Get the About page to look like design
  • Create a base Carousel that needs images when design is done

Type of Changes

Type
💄 UI Updates
✨ Enhancements

Updates

Before

Screenshot 2024-10-09 at 4 50 35 AM Screenshot 2024-10-09 at 4 50 42 AM Screenshot 2024-10-10 at 3 47 49 AM

After

Screenshot 2024-10-09 at 4 50 49 AM Screenshot 2024-10-09 at 4 50 54 AM Screenshot 2024-10-10 at 3 47 34 AM

Testing Steps / QA Criteria

  • Click the preview link in the PR
  • Make sure all the buttons of the nav bar at the top still take you to the spots that are needed
  • Open the dev tools and test a phone between 430px - 412px media points should have the hamburger menu
  • make sure in mobile view can still navigate

@bbland1 bbland1 self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit a14d5a9):

https://tcl-77-smart-shopping-list--pr64-bb-header-design-599hqdog.web.app

(expires Thu, 24 Oct 2024 22:03:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72

@bbland1 bbland1 added the enhancement New feature or request label Oct 9, 2024
@bbland1 bbland1 marked this pull request as ready for review October 9, 2024 08:59
@bbland1 bbland1 marked this pull request as draft October 10, 2024 04:30
@bbland1 bbland1 changed the title Bb/header design Header Design & Carousel Base + About page Oct 10, 2024
* adding the borders and positioning the text areas on the page

* figuring out some spacing on thank you & creators with theme-colors set

* getting the lin icons to space evenly and the same on all of them

* fixing the margins of the page for the whole about page

* getting the base of the carousel with image working

* card title on carousel card
@bbland1
Copy link
Collaborator Author

bbland1 commented Oct 10, 2024

The carousel is a skeleton with a sample picture once we get the designing finished screen shots can be taken and it can be finished but as a base it is ready.

@bbland1 bbland1 marked this pull request as ready for review October 10, 2024 07:51
@eternalmaha
Copy link
Collaborator

eternalmaha commented Oct 12, 2024

These changes look incredible!!! So much work and passion went into this. What does the whole team think about having the carousel captions displayed to the left or right of the carousel image? It'd be easier to visually see and follow the directions with the image...I think. I know the carousel is a work in progress still, and subject to a lot more changes as we go! :)

Also! I like that you're using the word skeleton now hahaha!!!

@RossaMania
Copy link
Collaborator

I LOVE this! I was playing with various cell phone views and I did notice the Create List was chopped off. Theoretically though, users should be able to turn phone sideways and it should work okay? "?" in there because my Inspect mode in Chrome isn't letting me view pages as if a device is turned sideways anymore. Great work though!
image

@bbland1
Copy link
Collaborator Author

bbland1 commented Oct 15, 2024

@RossaMania your catch help me realized I put the wrong preview link in the tests but also made me double check what is looked like on my phone 🤦🏽‍♀️😂

The button maybe needs to be adjusted but it should fit on the screen and change. I'm not near a computer to check but I will!

image

Copy link
Collaborator

@RossaMania RossaMania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Very cool! I love the use of classes! Actually using svg files for the GitHub logo and LinkedIn logos are a nice touch!

@bbland1 bbland1 added the design label Oct 15, 2024
@bbland1 bbland1 merged commit 101c350 into main Oct 17, 2024
2 checks passed
@bbland1 bbland1 deleted the bb/header-design branch October 17, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request
Projects
None yet
4 participants