generated from the-collab-lab/smart-shopping-list
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14.5: Implement LandingPage Component & Enhance Navigation UI #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate LandingPage to render SignInButton as an IconButton in the navbar
Visit the preview URL for this PR (updated for commit d5a9210): https://tcl-74-smart-shopping-list--pr41-sd-dt-landingpage-xmi570jt.web.app (expires Wed, 09 Oct 2024 16:25:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
dterceroparker
changed the title
14.5 Create <LandingPage> Component #39
14.5 Implement LandingPage Component & Enhance Navigation UI #39
Sep 30, 2024
dterceroparker
changed the title
14.5 Implement LandingPage Component & Enhance Navigation UI #39
14.5 Implement LandingPage Component & Enhance Navigation UI
Sep 30, 2024
…to use relative paths for manage-list
… the navbar still persists
dterceroparker
changed the title
14.5 Implement LandingPage Component & Enhance Navigation UI
Issue #14.5: Implement LandingPage Component & Enhance Navigation UI
Oct 1, 2024
…; add redirect to LandingPage for /manage-list when user is not signed in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR involves the development of a LandingPage component for the CollabShop application. The component will feature a placeholder logo, a product description, and a footer navigation bar that includes a "Meet the Team" icon and a "Sign In" button that navigates to application page.
Related Issue
Closes #39
Acceptance Criteria
LandingPage
component.Layout.jsx
to ensure the Sign In button is not displayed in the UI.useAuth.jsx
to support passing a className prop and integrate FontAwesome icons.LandingPage.css
, to style the LandingPage component.Type of Changes
Enhancement
Updates
Before
After
Testing Steps / QA Criteria