[TCL30-70] Update Pins on Map #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sharing location.
|
Visit the preview URL for this PR (updated for commit dab39d5): https://tcl-30-whats-near-me-d2e34--pr37-jw-update-pins-vcsd4dq2.web.app (expires Sat, 11 Sep 2021 02:34:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
alxmcr
reviewed
Sep 4, 2021
| @@ -265,8 +265,9 @@ a.active { | |||
| width: 24px; | |||
| height: 24px; | |||
| cursor: pointer; | |||
| border: 2px solid #1c2334; | |||
| background: grey; | |||
| border: 2px solid var(--primary-color); | |||
alxmcr
reviewed
Sep 4, 2021
| @@ -307,15 +308,16 @@ a.active { | |||
| .user-location-icon { | |||
| width: 180px; | |||
| height: 180px; | |||
| fill: #a020f0; | |||
| fill: var(--primary-color); | |||
alxmcr
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the styling of the pins associated with available locations on current map view. It also updates the styling of the pin representing the user when they are sharing their location.
Related Issue
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
v2-whats-near-mejw-update-pinsnpm start/, share your location. Your icon should be pulsing shades of green. Pin locations should have a green border.