TCL30-69 - Add icons to slider to settings page #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d107a90): https://tcl-30-whats-near-me-d2e34--pr36-ac-settings-slider-0n1aoaaz.web.app (expires Sat, 11 Sep 2021 01:44:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
alxmcr
requested review from
laurenmbeatty,
segdeha,
meganmckissack and
jssckbl
jssckbl
reviewed
Sep 4, 2021
src/App.css
Outdated
| } | ||
|
|
||
| .thumb { | ||
| box-sizing: border-box; | ||
| top: 1px; | ||
| width: 50px; | ||
| height: 48px; | ||
| border: 5px solid gray; | ||
| background-color: black; | ||
| border: 5px solid black; |
There was a problem hiding this comment.
It might be nice to have the border be the secondary color instead of black.
|
This is fantastic! The slider is working quite well, and the icons came very nicely, too 🥳 I hope it is okay, but I am going to change the outline color of the main part of the slider, and I will check out the CSS to remove the "Barlow" font and have "Merriweather" be the font for the content of the settings page. Quite minor things, really! Overall, this is great, @alxmcr 👍 |
… Merriweather as listed in Figma.
jssckbl
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add icons to slider to the settings page
Related Issue
TCL30-69
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
ac-settings-slider/settings