Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCL30-60] Remove fill color & unify sizes in SVG files #27

Merged
merged 5 commits into from
Aug 30, 2021

Conversation

alxmcr
Copy link
Contributor

@alxmcr alxmcr commented Aug 30, 2021

Description

As a user

I would like to see the SVG icons without fill color

So that I can change the fill color easier.

Related Issue

TCL30-60

Acceptance Criteria

  • Remove fill color in SVG files.
  • Unify sizes in SVG files.
  • Only for testing:
    • Create an additional page UIComponentsPage
    • Add a new route /UI

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

  • We added a new route /ui only for testing purposes.
  • Default SVG sizes: 20 x 20 (Note.- In some cases, standard sizes couldn't change the sizes).

image

Testing Steps / QA Criteria

  1. Pull the last changes in your local machine.
  2. Change to ac-remove-fill-color-svg-icons branch.
  3. Go to /ui route.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 3ebb731):

https://tcl-30-whats-near-me-d2e34--pr27-ac-remove-fill-color-srdnurqy.web.app

(expires Mon, 06 Sep 2021 19:44:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@alxmcr alxmcr self-assigned this Aug 30, 2021
@alxmcr alxmcr marked this pull request as ready for review August 30, 2021 19:47
Copy link
Contributor

@laurenmbeatty laurenmbeatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good 👍 . If we had more time we could engineer a fancier Icon component, but that would take awhile.

@jssckbl jssckbl merged commit 94eda14 into v2-whats-near-me Aug 30, 2021
@alxmcr alxmcr deleted the ac-remove-fill-color-svg-icons branch August 31, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants