Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get over obsolescences #7

Merged
merged 4 commits into from
Sep 7, 2020
Merged

get over obsolescences #7

merged 4 commits into from
Sep 7, 2020

Conversation

amateja
Copy link
Contributor

@amateja amateja commented Jul 16, 2018

This PR is aimed to get over obsolescences in this project and its dependencies with a few dependencies fixes.

  1. pep8 project was renamed to pycodestyle (see Please rename this tool PyCQA/pycodestyle#466)
  2. pyflakes has dropped python 3.3 support in version 2.0.0 (see Drop support for EOL Python <2.7 and 3.2-3.3 PyCQA/pyflakes#322)
  3. missing PyYAML dependency included in setup.py script
  4. unused textwrap import removed
  5. global import pattern with try/catch clause replaced with python agnostic single local import
  6. missing empty lines added to satisfy PEP8 guidelines (see https://www.python.org/dev/peps/pep-0008/?#blank-lines)
  7. nose does not need to be present in order for the setup.py script to run (https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords)
  8. makefile targets were updated but backward compatibility is maintained
  9. unsupported rstcloth.cloth.Cloth.print_block and rstcloth.cloth.Cloth.write_block methods and unused rstcloth.table.fill function were removed
  10. unsupported block and block_order parameters were removed

amateja and others added 4 commits July 16, 2018 11:25
* pep8 project was renamed to pycodestyle
* pyflakes has dropped python 3.3 support in version 2.0.0
* missing PyYAML dependency included in setup.py script
* unused textwrap import removed
* global import pattern with try/catch clause replaced with python
  agnostic single local import
* missing empty lines added to satisfy PEP8 guidelines
* nose is not need to be present in order for the setup script to run
* makefile targets were updated but backward compatibility is maintained
@thclark thclark merged commit 5b56b99 into thclark:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants