New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FQDN Validation: FQDNs with fourth-level domain aren't considered valid #180

Closed

handymenny opened this issue Dec 21, 2021 · 0 comments

Assignees

Labels

accepted bug fixed-in-next-release

handymenny commented Dec 21, 2021 •

edited

Loading

Bug Description

If I sumbit an FQDN with a fourth-level domain, hyperglass responds with this error: 'XXX is not a valid Traceroute target'.

An example of valid domains that trigger this error are:

ec2-18-194-0-252.eu-central-1.compute.amazonaws.com
r3.sn-fpoq-o52l.googlevideo.com

Expected behavior

hyperglass should consider these domains valid and proceed with DNS resolution

Possible Solution

Replace fqdnPattern regex with:
/^(?!:\/\/)([a-zA-Z0-9-]+\.)*[a-zA-Z0-9-][a-zA-Z0-9-]+\.[a-zA-Z-]{2,6}?$/im

The text was updated successfully, but these errors were encountered:

handymenny added the possible-bug label

handymenny changed the title ~~FQDN Validation: FQDNs with fourth-level domain (or higher) aren't considered valid~~ FQDN Validation: FQDNs with fourth-level domain aren't considered valid

thatmattlove added accepted bug fixed-in-next-release and removed possible-bug labels

thatmattlove self-assigned this

thatmattlove added a commit that referenced this issue


          Fixes #180: properly validate long FQDNs

433b5ce

thatmattlove closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment