Query Frontend: Add tests and fix previous bugs for instant query tripperware #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
commented
Aug 19, 2022
| @@ -34,6 +34,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| - [#5575](https://github.com/thanos-io/thanos/pull/5575) Receive: Add support for gRPC compression with snappy. | |||
| - [#5508](https://github.com/thanos-io/thanos/pull/5508) Receive: Validate labels in write requests. | |||
| - [#5439](https://github.com/thanos-io/thanos/pull/5439) Mixin: Add Alert ThanosQueryOverload to Mixin. | |||
| - [#5561](https://github.com/thanos-io/thanos/pull/5561) Query Frontend: Support instant query sharding. | |||
There was a problem hiding this comment.
This is added for previous pr.
| cortexpb.Sample scalar = 1; | ||
| StringSample stringSample = 2; | ||
| Vector vector = 3; | ||
| Matrix matrix = 4; |
There was a problem hiding this comment.
Handled all 4 cases mentioned in https://prometheus.io/docs/prometheus/latest/querying/api/#instant-queries.
yeya24
changed the title
added 3 commits
August 19, 2022 00:19
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
handle-string-result
branch
from
93d3ddd to
6ea881e
Compare
fpetkovski
reviewed
Aug 20, 2022
Tests added in 3804c99. PTAL |
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
handle-string-result
branch
from
b0a77fd to
3804c99
Compare
added 2 commits
August 20, 2022 11:54
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
|
cc @fpetkovski @GiedriusS for another look 😄 |
|
Need another approval from maintainers and then we can start cutting the rc. |
GiedriusS
approved these changes
Aug 22, 2022
|
💪 |
GiedriusS
pushed a commit
to vinted/thanos
that referenced
this pull request
Aug 25, 2022
…pperware (thanos-io#5612) * fix string type result; add more tests for instant query sharding Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix imports Signed-off-by: Ben Ye <ben.ye@bytedance.com> * support matrix type response Signed-off-by: Ben Ye <ben.ye@bytedance.com> * add unit tests for decoding responses Signed-off-by: Ben Ye <ben.ye@bytedance.com> * rename ShardedRequest interface Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix lint Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Follow up PR for #5561.
Changes
stringandmatrixfor instant queries. Those types are not handled correctly in the previous pr.Verification