query: fix deadlock in endpointset #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid RLock()ing twice as described here: thanos-io#4766 (comment) (due to https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188). Fix it by removing HasClients() and simply changing it with `er.clients != nil`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
yeya24
approved these changes
Oct 21, 2021
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this pull request
Oct 22, 2021
Avoid RLock()ing twice as described here: thanos-io#4766 (comment) (due to https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188). Fix it by removing HasClients() and simply changing it with `er.clients != nil`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
|
Hi @GiedriusS @squat , I found at least 4 people report this bug, it critical because query will halt . Could we released a miro version like 0.23.2, just cherry pick this import pr. Thanks very much. |
|
This PR is in the release candidate for 0.24.0. i think that's enough. Or do you think it's so severe that we need to back port the fix? |
|
@squat I think it's severe to do that. Someone use 0.23.x always face this deadlock issue, the query api will halt and process will not auto reboot, It will be nice to have 0.23.2 for 0.23.x series. 😄 I am also face this issue on production upgrade, other case like https://cloud-native.slack.com/archives/CK5RSSC10/p1637585247351700 https://cloud-native.slack.com/archives/CK5RSSC10/p1637265253335900 . |
aymericDD
pushed a commit
to aymericDD/thanos
that referenced
this pull request
Dec 6, 2021
Avoid RLock()ing twice as described here: thanos-io#4766 (comment) (due to https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188). Fix it by removing HasClients() and simply changing it with `er.clients != nil`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
aymericDD
pushed a commit
to aymericDD/thanos
that referenced
this pull request
Dec 7, 2021
Avoid RLock()ing twice as described here: thanos-io#4766 (comment) (due to https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188). Fix it by removing HasClients() and simply changing it with `er.clients != nil`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Aymeric <aymeric.daurelle@cdiscount.com>
bwplotka
pushed a commit
that referenced
this pull request
Dec 7, 2021
Avoid RLock()ing twice as described here: #4766 (comment) (due to https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188). Fix it by removing HasClients() and simply changing it with `er.clients != nil`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Aymeric <aymeric.daurelle@cdiscount.com> Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
george-angel
added a commit
to utilitywarehouse/thanos-manifests
that referenced
this pull request
Dec 22, 2021
Mainly to address thanos-io/thanos#4795 - which is happening frequently in prod-aws/sys-mon
george-angel
added a commit
to utilitywarehouse/thanos-manifests
that referenced
this pull request
Dec 22, 2021
Mainly to address thanos-io/thanos#4795 - which is happening frequently in prod-aws/sys-mon
JoaoBraveCoding
added a commit
to JoaoBraveCoding/cluster-monitoring-operator
that referenced
this pull request
Nov 4, 2022
Issue: https://issues.redhat.com/browse/OCPBUGS-2037 Problem: thanos-io/thanos#4766 Solution: update to 0.23.2 that contains the patch thanos-io/thanos#4795 Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid RLock()ing twice as described here:
#4766 (comment)
(due to
https://stackoverflow.com/questions/30547916/goroutine-blocks-when-calling-rwmutex-rlock-twice-after-an-rwmutex-unlock/30549188).
Fix it by removing HasClients() and simply changing it with
er.clients != nil.Closes #4766.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com